Skip to content

Support selecting theme on the footer #35741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 28, 2025
Merged

Support selecting theme on the footer #35741

merged 8 commits into from
Oct 28, 2025
+254 −59

Conversation

@wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Oct 24, 2025 •
edited by silverwind
Loading

Fixes: #27576

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 24, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/frontend labels Oct 24, 2025
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Oct 24, 2025 •
edited
Loading

image image

@wxiaoguang wxiaoguang mentioned this pull request Oct 24, 2025
Closed
@wxiaoguang wxiaoguang force-pushed the support-theme-select branch 3 times, most recently from 73de799 to af7cbfd Compare October 24, 2025 17:29
@wxiaoguang wxiaoguang force-pushed the support-theme-select branch from af7cbfd to e884b35 Compare October 24, 2025 17:46
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 24, 2025
@lunny lunny added this to the 1.26.0 milestone Oct 24, 2025
@wxiaoguang wxiaoguang changed the title Support select theme on the footer Support selecting theme on the footer Oct 25, 2025
@silverwind
Copy link
Member

Maybe there is a better colorblind icon, like "eye with cross"? If not deemed ok, I would at least make the white part of the current icon transparent, it looks odd on dark theme.

silverwind
silverwind reviewed Oct 27, 2025
View reviewed changes
silverwind
silverwind reviewed Oct 27, 2025
View reviewed changes
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Oct 27, 2025 •
edited
Loading

Maybe there is a better colorblind icon, like "eye with cross"? If not deemed ok, I would at least make the white part of the current icon transparent, it looks odd on dark theme.

I have thought about "eye with cross", but it reads like "blind" or "closed eyes".

This icon is from GitHub:

image

And use transparent background: d567924

silverwind
silverwind reviewed Oct 28, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 28, 2025
@wxiaoguang wxiaoguang merged commit 6b5563c into go-gitea:main Oct 28, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the support-theme-select branch October 28, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

4 participants

@wxiaoguang @silverwind @lunny @GiteaBot